knuu icon indicating copy to clipboard operation
knuu copied to clipboard

Add delete function to Preloader

Open smuu opened this issue 2 years ago • 2 comments

call EmptyImages()

smuu avatar Jun 22 '23 10:06 smuu

is this okay?

func NewPreloader() (*Preloader, error) {
	k8sName, err := generateK8sName("knuu-preloader")
	if err != nil {
		return nil, fmt.Errorf("error generating k8s name for preloader: %w", err)
	}
	preloader := &Preloader{
		k8sName: k8sName,
		images:  []string{},
	}
	err = preloader.EmptyImages()
	if err != nil {
		return nil, err
	}
	return preloader, nil
}

salehshoji avatar Jun 26 '23 07:06 salehshoji

Thanks for the question @salehshoji :rocket:

I meant adding func (p *Preloader) Delete() error, which in the implementation can call EmptyImages().

smuu avatar Jul 06 '23 08:07 smuu