Sergio Moya

Results 326 comments of Sergio Moya

> From my perspective I'm connecting to a STOMP server over WebSocket, not communicating with a WebSocket server using STOMP. No problem @Crain-32! I edited my [previous comment](https://github.com/asyncapi/spec/issues/787#issuecomment-1175481699) to clarify...

> stomp and others could be referenced inside ws in a new field called subprotocols. Now I realize you meant to use `$ref` under `subprotocols` field to reference the `stomp`...

@fmvilas @derberg @dalelane would you mind removing `stale` label? thanks

> Is anything stopping us from merging this? 🤔 I guess the approval from the rest of the owners, e.g. @derberg @dalelane

> the errors are all HTTP-429 Ideally, the action would accept a header with a valid GH token, so request rate can be higher than actually needed. However there is...

@magicmatatjahu Why this PR is targetting `next-major-spec` instead of `next-spec`? I can't see where the breaking change is (most probably missing something). As a minor comment, the title prefix would...

> @smoya I thought it better not to add it to 2.X.X but to 3.0.0 despite the lack of breaking changes. As for `chore:` I don't know how the release...

> While working on 3.0.0, we'll find a bunch of things that are not BC and could potentially be added to 2.x. However, IMHO, we must be careful not to...

> releasing a patch doesn't hurt 😄 we just merge and it magically happens 😄 > > all good on JSON Schema side? All good as `$ref` is allowed as...

@dalelane ~@fmvilas~ your review is needed here. Thanks!