Chris Smowton

Results 20 issues of Chris Smowton

This will make post-update nodes easy to implement. Queries / tests that required changes: * The CleartextLogging and MissingErrorCheck queries are updated because they assumed def-use flow * The CommandInjection...

This is abandoned external PR https://github.com/github/codeql/pull/6716, but I have also written tests and ported the hardcoded-creds queries to use inline-expectations tests so it's practically possible to verify that the results...

documentation
Java

Steps into captured variables are moved into jumpStep where they always should have been, and the store/load step implementation for channels is completed. For the time being this takes a...

documentation
Go

As documented at https://kotlinlang.org/docs/annotations.html#constructors, annotation properties of type KClass get rewritten when targeting the JVM.

Kotlin

Kotlin's implementation of defaults depends on the -Xjvm-default setting (or the `@JvmDefault` deprecated annotation, not implemented here): by default, actual interface class files don't use default methods, and any class...

Java
no-change-note-required
Kotlin

**Describe the bug** Received message `no result from server` on running a quick query. Immediately preceding extension log: ``` [2021-07-01 08:29:46] [DETAILS] resolve qlpacks> Scanning for qlpack.yml from /Users/chris/vscode-codeql-starter/codeql-custom-queries-cpp/ [2021-07-01...

bug
VSCode

This generates functions that omit parameters with default values, rightmost first, such that Java can achieve a similar experience to Kotlin (which represents calls internally as if the default was...

Java
no-change-note-required
Kotlin

Happens about half the time I select a new database, make a quick query and try to run it: ``` com.semmle.util.exception.UserError: Database is not registered: /private/tmp/db at com.semmle.cli2.execute.queryServer2.QueryServer2BackendManager.withDB(QueryServer2BackendManager.java:175) at com.semmle.cli2.execute.queryServer2.QueryServer2BackendManager.withDBShared(QueryServer2BackendManager.java:70)...

VSCode

Per @max-schaefer `codeql run test` should adapt queries that emit absolute FS paths such that they pass when run in a different environment. For example my test emits `# 0|...

CLI

documentation
Java
ready-for-doc-review