Dan Balasescu
Dan Balasescu
I would be interested if you are able to use https://github.com/ppy/osu-localisation-analyser. It's made for this purpose, but hasn't been tested outside of osu! yet. Add it to your project via...
It doesn’t support that yet. What we could do is add support via either an attribute on the class or namespace forwarding in .editorconfig. Any preference or other suggestions?
> * Any strategy to check the duplicated translation strings? Or even merge them? Maybe I'm not understanding, but it should be doing this already. For both the class and...
> But does that means it can have more than one `CommonStrings.cs` in the different namespace? As I said I'm not sure about this, and I think it's best for...
> Then user can add the localization to the any class matched to the `Localisation/Chat/*Strings.cs.` > I think it will be better to let user easy to merge the localization...
See https://github.com/ppy/osu-framework/pull/5241 for an automated script
> Or will use `null!` in o!f and lazer? > > ``` > [Resolved] > private ILyricRubyTagsChangeHandler rubyTagsChangeHandler { get; set; } = null!; > ``` Yep, this is the...
Will eventually be non-null only, the second one above.
I'm investigating this one. Part of the issue seems to be the `AllowedImportantTimeSpan` check which exhibits different behaviours with/without fast forwarding: https://github.com/ppy/osu/blob/f3184525107b29018d7271e7bbcf779eec7ad1d8/osu.Game/Rulesets/Replays/FramedReplayInputHandler.cs#L113-L114 Another part of the issue seems to be...
Yes, it's because the parent container is being masked away and children are placed outside of it.