ABDULRAHMAN ALRAHMA
ABDULRAHMAN ALRAHMA
Is this still valid? I can see that this decorator has been deleted here: https://github.com/maldoinc/wireup/blob/1a4942038ca449f9c936bc74b9a1d27a1032f1af/docs/pages/upgrading.md?plain=1#L17
> Something worth looking into here is null values/unions. So for example if the type is int | None then simple instance checks won't work. Could you explain this point...
> There's some issues with it in py38 at least. It seems after reading, that `isinstance` won't work also for some trivial cases like `List[str]` even with the latest python...
> That would be definitely going over the intended purpose. I think for now we can just restrict it to basic types like int,str,float,bool and warn then look to expand...
> Hi, thanks for this. I think it generally looks fine. I'll give it a more thorough review in a few days as I also want to think a bit...
@maldoinc addressed your comments. There is 1 test that broke after the changes: https://github.com/maldoinc/wireup/blob/6d62250ef0c5f3792e34a6857c6cbf952a016208/test/unit/test_container_core.py#L77-L93 What should be done do you think? (replaced the '.' with '_' in my PR for...
any updates regarding this?
> Thank you for raising this issue! I'll look into it and try to help if I can. Thank you so much. I've raised some questions on the original issue....
@birkjernstrom I can take this up