sepp icon indicating copy to clipboard operation
sepp copied to clipboard

Dendropy v4.6.0 causing SEPP to break

Open berkelem opened this issue 1 year ago • 9 comments

A new version of Dendropy was released a week ago and it is causing the SEPP conda build to break. Could you look into this and either update SEPP to maintain compatibility or update the conda recipe to restrict it to older versions of Dendropy?

berkelem avatar Apr 28 '23 22:04 berkelem

I think I am having the same problem. I keep getting this error - ImportError: cannot import name '_convert_node_to_root_polytomy' from 'dendropy.datamodel.treemodel'

ncolaian avatar May 11 '23 01:05 ncolaian

CC @mmore500

lh3 avatar May 19 '23 02:05 lh3

Taking a look!

mmore500 avatar May 19 '23 14:05 mmore500

Opened #126 with a patch for sepp and made note of the fact that this logic is currently only accessible via "private" (i.e., _*) interface in dendropy (https://github.com/jeetsukumaran/DendroPy/issues/169). Will contribute another patch once we create and release a public interface for _convert_node_to_root_polytomy. :)

mmore500 avatar May 19 '23 15:05 mmore500

Hello,

I am having the same issue : ImportError: cannot import name '_convert_node_to_root_polytomy' from 'dendropy.datamodel.treemodel'

any solution for that ?

nicolo-tellini avatar Feb 11 '24 12:02 nicolo-tellini

Hi @nicolo-tellini

Pinning dendropy==4.5.2 within your runtime environment should fix this issue. You’l need to use your package manager (pip, poetry, conda, etc.) to accomplish this.

mmore500 avatar Feb 12 '24 00:02 mmore500

Hi @mmore500 ,

thank you very much it works nicely

best

nic

nicolo-tellini avatar Feb 12 '24 08:02 nicolo-tellini

@mmore500 Thanks a ton for your PR and sorry I am so slow these days with these. I hope the merged PR fixes the issue?

smirarab avatar Feb 12 '24 15:02 smirarab

Yes! Thank you @smirarab :)

I don't have a button to close this issue, but if you do it should be able to be closed

mmore500 avatar Feb 25 '24 01:02 mmore500