Shoaib Meenai
Shoaib Meenai
How is the NDK generating order files? At Meta, we introduced a lightweight IR PRO instrumentation mode specifically for mobile and an order file generation mode algorithm aimed at minimizing...
IIRC `-forder-file-instrumentation` is older and has higher binary size overhead than lightweight IR PGO. I'll ask Ellis (who contributed lightweight PGO) to comment here though.
I've been evaluating ghstack for use in LLVM, which is switching from Phabricator to GitHub PRs and looking for a solution for stacked PRs. Requiring force pushes is a deal-breaker,...
> I've been evaluating ghstack for use in LLVM, which is switching from Phabricator to GitHub PRs and looking for a solution for stacked PRs. Requiring force pushes is a...
The merge action would need to be set up for the repository though, right? Also, if I'm understanding https://github.com/taichi-dev/taichi/commit/037db43e92c4330d483626f3cadcebca194a03be correctly, it's still using `ghstack land` under the hood?
I believe this is the same as #187, where the check is at the start of the loop before a new argument will be inserted, so it's correct to report...
#569 has landed, so we should be good to close this out.
#32 had some prior discussion of this, and we're running into it again in #962
Note that code outside a case isn't necessarily dead, because you can do things like https://godbolt.org/z/PqEGzKEzb to reach it.
I'm noting down what I've researched here so far. This is probably old news for everyone else, I'm just writing it down for my own benefit. Laying out records (classes,...