TiDAKeyboardControl icon indicating copy to clipboard operation
TiDAKeyboardControl copied to clipboard

Handle TabBar

Open Topener opened this issue 9 years ago • 4 comments

would be great if TabBar can be handled properly.

With native code this is easy, but with a module a little less. Is there a way to add a flag so it can be handled in a tabbar too?

Issue here: https://github.com/danielamitay/DAKeyboardControl/issues/42

Topener avatar Feb 02 '16 16:02 Topener

The best way I can think of is to add a lockedViewsMinOffset property to be used at this line to manage a minimum value it must have.

Would you mind to make the changes? I’ll gladly accept them.


Thank you for using this module!!

yuchi avatar Feb 02 '16 16:02 yuchi

Yeah that sounds like a great addition.

But I'm afraid I don't have any knowledge of Obj-c, and I'd like to change it but not the time to do it just now...

Topener avatar Feb 02 '16 16:02 Topener

I would like to update the module and send a PR, but I can't clone the full project. I get this

`Cloning into '/Users/Migue/Documents/NubecitaSVN/TiDAKeyboardControl/DAKeyboardControl'... Permission denied (publickey). fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists. fatal: clone of '[email protected]:danielamitay/DAKeyboardControl.git' into submodule path '/Users/Migue/Documents/NubecitaSVN/TiDAKeyboardControl/DAKeyboardControl' failed Failed to clone 'DAKeyboardControl'. Retry scheduled Cloning into '/Users/Migue/Documents/NubecitaSVN/TiDAKeyboardControl/DAKeyboardControl'...`

@yuhi can you check it? Thanks.

macasfaj avatar Jul 24 '17 10:07 macasfaj

There could be some problems with the git submodule. Thanks for caring @macasfaj, I’ll have a look soon.

yuchi avatar Jul 25 '17 09:07 yuchi