Sam Burdick
Sam Burdick
I can take this on.
I'm interested in taking this one on.
I'm realizing this should be nondeterministic?
I can take this on. I can use my own local Windows/MacOS environments to reproduce the issues.
https://github.com/quantumlib/Cirq/commit/3c6a305bb88b93b197c8c98762013baa1134f41e removed all but one of the `skipif(sys.platform != "linux", reason="Linux-only test")` tags. The remaining one is in `dev_tools/notebooks/notebook_test.py` which failed in integration testing.
From the macOS output: ``` dev_tools/notebooks/notebook_test.py:123: Failed ----------------------------- Captured stdout call ----------------------------- /bin/sh: line 1: papermill: command not found ``` `papermill` is included in `dev_tools/requirements/deps/notebook.txt`. Let's have pip install that...
Windows output: ``` -r: D:\a\_temp\c0ad28f8-cc4a-442c-b165-389fe89d7f5e.ps1:4 Line | 4 | -r dev_tools/requirements/deps/format.txt \ | ~~ | The term '-r' is not recognized as a name of a cmdlet, function, script file,...
https://github.com/quantumlib/Cirq/commit/30b6c3908e36c58299e920f03803c0f9d8d23668 addresses macOS bug. Will begin on Windows side now.
I'm a little out of my depth on the Windows side of things (all my dev experience is Unix). I will pick up something else. Thanks!
> Thanks Sam for the comments here. It's really important that we have clear development documentation. > > I'm not totally clear on what you're suggesting, however. Would you mind...