Xianxiang Li

你应该创建 Pull Request 来帮他改正。

> It has been a while since I looked at this, but it looks like it still needs tests. Before I move on, I have to address the current test...

The file etopo1.jpg is not empty. its size is 1.28M (64 dpi). it is the picture of the bathymetry data to plot. I took it from Basemao repo, because the...

> I think grabbing it from the source is better whenever possible, that way we get any updates they have. It also looks like there are multiple "versions" of etopo,...

Now I have modified the code to download the etopo1 image from NOAA website, and delete the etopo1.jpg file from the commit.

> Can you rebase your commits to "squash" together the original commit adding the file and the one deleting it? Otherwise, there will be a copy of the 1.3MB file...

> this PR appears to be reviwed and have passing tests, but there are conflicts between it and master > > @smartlixx please may i suggest that you `rebase` this...

> Looks good to me, just one minor suggestion. > Thanks for your comments. I have updated the PR to incorporate the new changes since my last commit, and the...

You can have a look at #4556, and perhaps somebody should work further to implement a PR.