Steven Malis
Steven Malis
Please add a description that is more than just the PR title.
I guess could be done by visiting the whole record instead of relying on Metadata and enabled? It'd be nice if this could all be handled in enabled though.
1 is exactly what I had in mind, and might be a good addition in general. 2 is an interesting thought, but I think we could also just skip certain...
Or perhaps 1 should include a new KeyMetadata struct that can include more than just the name? Either way works.
Agreed with everyone here, in our case it's only triggering on locals that are immediately passed to function calls that wouldn't typecheck otherwise. Should this lint be downgraded to a...
Now that we have a 2411 fork producing artifacts, this should be doable? Steps would be to bless some build as 'official', artifact it somewhere, then update the test infra...
We should also look at any places we're using inspect internally and decide if it's safe for those calls to inspect sensitive state or not. edit: this is done.
Think the title and description need updating
Well it's still a WIP, but the change we're actually making is the opposite of the current title
Yes, panic messages should still get logged in a debug-disabled CVM. One of the things I'm working on this week is validating that.