openvmm icon indicating copy to clipboard operation
openvmm copied to clipboard

CVM: Audit tracing and add ALLOWED/CONFIDENTIAL where appropriate

Open smalis-msft opened this issue 7 months ago • 3 comments

Also includes some drive-by cleanups where I happened to see them.

Areas I did not audit because they are not relevant to CVMs:

  • trace and debug level statements
  • Non-CVM workers (debug & VNC)
  • Test only code (petri, vmm_tests, tmk*)
  • ARM-specific code
  • Non-CVM virt backends (including virt_mshv_vtl/mshv)
  • Host-only code (openvmm, GED, igvmfilegen, etc)
  • Gen 1 devices (vga, chipset, etc)
  • VirtIO

Areas that still need auditing by owners and area experts:

  • Mesh (@jstarks)
  • Networking (vm/devices/net/* & underhill_core/netvsp) (networking team)
  • Storage (vm/devices/storage/* & underhill_core/nvme_manager) (storage team)
  • VMBus (vm/devices/vmbus/*) (@SvenGroot)
  • VMGS (vm/vmgs/*) (@tjones60)

Part of #852

smalis-msft avatar May 23 '25 21:05 smalis-msft

            panic!("Received unexpected SEV exit code {sev_error_code:x?}");

does this get logged in a debug-disabled CVM? If not, do we want a non-specific error message logged for this case?


Refers to: openhcl/virt_mshv_vtl/src/processor/snp/mod.rs:1575 in 8476372. [](commit_id = 84763729da9b5bde08ea7a4b64dd426a041f51f1, deletion_comment = False)

mebersol avatar May 25 '25 17:05 mebersol

Yes, panic messages should still get logged in a debug-disabled CVM. One of the things I'm working on this week is validating that.

smalis-msft avatar May 27 '25 14:05 smalis-msft

Backported in #1460

benhillis avatar Jun 04 '25 16:06 benhillis