Maxim Sukharev

Results 141 comments of Maxim Sukharev

Please try: click on select, type the number, click on it. Like that don't need to scroll and can jump to specific file pair. Does it work for you? Or...

Ah! We have `(` in the front of the number. That's why it doesn't work. Thanks! Then we need to find another solution. Maybe something like this: https://select2.org/searching ?

Duplicate of https://github.com/src-d/code-annotation/issues/113 I suggested it because of invisible symbols but it's just a guess. We need to check.

Just few examples with replaced invisible characters: Number 6: Number 29:

+1 to the proposal with the wrapper. Only one small idea, maybe you don't need to change `serializer.NewHTTPError` (it accepts status and message). Maybe it's better to create `serializer.NewError(err error)`...

I checked the source code and it looks like we return correct error everywhere now. For our current use cases when we return not 500 we don't need to log...

Yeah. I meant to work like that. Misread code. Fix is here: https://github.com/src-d/code-annotation/pull/84

original comment got collapse. So here it is: @dpordomingo : > With the current wording, I understand the following: > > UI to annotate, > CLI to fetch (retrieve/download...) elements...

Guys do you think we still need to document `export` in readme when we have a link in UI?