code-annotation icon indicating copy to clipboard operation
code-annotation copied to clipboard

Suspicious highlights

Open EgorBu opened this issue 7 years ago • 4 comments

Hi, I noticed at pair 6 something suspicious. Code & comments are the same in both samples but everything is marked as changed (even without reusing of anything that can happen in case of some changes). Screen is below cat_pair_6 If it's because of some changes like new line windows \r\n-> linux \n it could be worth to add Show whitespaces button or show them by default

EgorBu avatar Feb 27 '18 18:02 EgorBu

Duplicate of https://github.com/src-d/code-annotation/issues/113

I suggested it because of invisible symbols but it's just a guess. We need to check.

smacker avatar Feb 27 '18 18:02 smacker

Thank you, I could not find a similar issue. I (or you) can close issue as duplicated if you wish

EgorBu avatar Feb 27 '18 18:02 EgorBu

Pair number 6, 19, 22, 29, 54, 57, 104, 111, 115, 159, 183, 187, 210, 217, 261, 268, 284, 305, 318, 337, 338, 369, 378, 379, 387, 388, 394, 451, 475, 476, 499, 504, 505, 507 (lines 198 to 203, 252 to 266), 583, 594, 640, 649, 674, 700, 704, 730, 744, 757, 758 (strange diff beahviour), 787, 814, 833, 834, 838, 852, 871, 873, 879, 881, 897, 986, 1004, 1011, 1018, 1128, 1237, 1371, 1426, 1428, 1429, 1459, 1462 have the same confusing highlights. I will track of suspicious pairs in this comment

In some cases, it makes almost impossible to put a correct label. Ex: pair 394 - were comments changed? Or something else too? There are several hundred lines, so it's hard to bisect correctly changes manually

EgorBu avatar Feb 28 '18 09:02 EgorBu

Just few examples with replaced invisible characters:

Number 6: screen shot 2018-03-02 at 17 44 25

Number 29: screen shot 2018-03-02 at 17 45 51

smacker avatar Mar 02 '18 16:03 smacker