Scott Lundberg
Scott Lundberg
I wonder if this is new with TF 2.3, could you try on 2.2 or 2.1 and see if the same issue happens?
Thanks for pointing this out. This is the same with XGBoost and was originally driven by the format there. I think the "right" convention is to match the output of...
@imatiach-msft please be persistent :) The issue is that when using the sklearn API we get an output that is 2D: ``` import shap import xgboost X,y = shap.datasets.adult() model1...
Makes sense. I won't be able to fix it until mid next week (Wed), but I agree that the first issue is clearly a bug. As for the second, let...
Great thanks! The first fix should certainly start with just TreeExplainer, since it just has to do with what type of object we were passed. Perhaps the second issue might...
Thank you! Sorry I was out for a while and let this PR just sit around. I updated it to mesh with some other PRs and once the tests pass...
Thanks for bringing this up! I didn't think about how this would happen during the refactor... The issue is that we just pushed a significant new/cleaner API for SHAP and...
@QuentinAmbard do you have any ideas here? It seems like something might be off the way this is getting deserialized.
I just checked and it worked for me on 2.2.2, could you share a full working example of the issue?
Thanks @DigitalPig ! You are right that about the categorical variable splits being a lot of work to support. The core TreeExplainer code assumes that trees split on individual features...