slozier

WebSocketHandshaker.ParseWebSocketProtocol throws a NullReferenceException

1

This occurs because `SubProtocolsSet is null` even when `SubProtocols` is set to something in `WebSocketListenerOptions`. A workaround is to `Clone` the options after creating them.

iter not called on subclasses of bytes

1

For example: ```py class test(bytes): def __init__(self): self.it= False def __iter__(self): self.it = True return self def __next__(self): raise StopIteration # via for loop t = test() for x in...

The builtin `open` method uses the preferred encoding (which can be obtained via `locale.getpreferredencoding(False)`) when opening a text file without specifying an encoding. On Linux/macOS this was incorrectly returning Windows...

Updates test_global to match CPython 3.8 which correctly reports the offset.

The problem in `test_httplib_stdlib` is more elusive. I see that the certificate chain passed to verify is empty, therefore the verification of a "good" certificate fails, but don't know why...

There appears to be two failures (only tested on Linux but I assume the issues are the same on macOS) 1. The timeout values (in `Socket.SendTimeout`) only being stored in...

Argument unpacking is done by calling ```py if (list.__len__() != 0) { return list.pop(0); } ``` until the list is empty. This is quite inefficient since `pop(0)` shifts the contents...

This is causing a failure in `test_urllibnet`. ```Python s = _socket.socket() open(s.fileno()) ```

In the 3.6 branch, `socket.__init__` uses `Converter.TryConvertToInt64` on the `fileno`. This is incorrect and probably should be something like `TryToIndex`. See comment by @BCSharp https://github.com/IronLanguages/ironpython3/pull/1507#issue-1306616504 for details.

To reproduce: ```py import _socket assert hasattr(_socket, "dup") ``` Causes failures in test_socket.