Sam Lantinga comments

Results 1875 comments of


                                            Sam Lantinga

Smooth resize on X11 using _NET_WM_SYNC_REQUEST

Thanks! Can you squash this to a single commit for review?

Smooth resize on X11 using _NET_WM_SYNC_REQUEST

This seems reasonable to me, @icculus? Is the expectation that the application will have already resized the backbuffer before the next swap buffers?

IME composition cursor moves incorrectly in SDL 2.26.5, 2.24.2 and 2.0.22

Can you use git bisect to find out where this broke?

Smooth resize on X11 using _NET_WM_SYNC_REQUEST

This PR looks reasonable to me. Are there any performance penalties for this PR when resizing is not active?

IME composition cursor moves incorrectly in SDL 2.26.5, 2.24.2 and 2.0.22

@zreedy, can you take a look?

Smooth resize on X11 using _NET_WM_SYNC_REQUEST

@numberZero, would you mind updating this PR so we can merge it for SDL 3.0?

IME composition cursor moves incorrectly in SDL 2.26.5, 2.24.2 and 2.0.22

@zreedy, ping?

IME composition cursor moves incorrectly in SDL 2.26.5, 2.24.2 and 2.0.22

This is fixed in 018ca39c45ee703e991ff35cefa9c005f950284f for SDL3, thanks!

SDL_getenv where SDL_GetHint should be used instead

It turns out there's quite a few of these. I think for the most part we want to turn these into hints or remove them.

SDL_getenv where SDL_GetHint should be used instead

> I believe these X11, Wayland and freedesktop.org interactions should probably stay plain environment variables, like `HOME` and `PATH`, because that's their standard behaviour across all libraries: > > ```...