Sam Lantinga
Sam Lantinga
> Currently there's also the `readability-braces-around-statements.ShortStatementLines` option set to 1, allowing very short if statements such as: > > ```c++ > if (x) return y; > ``` > > It...
What testing have you done to verify these changes and test the speedup?
We can turn this on and enable errors in SDL 3.0. We're about to switch over and I want to avoid big churn in the codebase before that happens.
Can you create a separate PR that fixes issues causing CI failure here? I'd like to merge that to SDL2, but not this PR.
> Just to make sure I'm getting this right. The PR should be targeting the `SDL2` branch with: > > * Only the fixes ? > * Should it include...
This is the list of third party code that should be excluded from clang-tidy: ``` include/SDL_egl.h include/SDL_hidapi.h include/SDL_opengl.h include/SDL_opengl_glext.h include/SDL_opengles2_gl2.h include/SDL_opengles2_gl2ext.h include/SDL_opengles2_gl2platform.h include/SDL_opengles2_khrplatform.h src/events/imKStoUCS.* src/hidapi/* (except for src/hidapi/SDL_hidapi.c) src/joystick/controller_type.c src/joystick/controller_type.h...
Now that your changes have been merged (squashed to make it easy to merge to SDL2 in a single commit), does CI succeed for this PR?
Can you squash this to a single commit for review?
How did you verify correctness, and what was your benchmark setup and results?
Conceptually this is fine with me, as long as it doesn't decrease readability of the headers by end users. If it does, then I would suggest a separate API definition...