Sebastien Loriot
Sebastien Loriot
> do you suggest to create a new function `apply_iterative_snap_rounding()` or simply to rename the parameter `do_snap` to `apply_iterative_snap_rounding` ? renaming the named parameter, provided Mael thinks it is a...
> > What do you think of `apply_iterative_snap_rounding()` ? cc @MaelRL > > I do not like an `apply_` prefix. Did you have a look at the [existing function for...
> > > What do you think of `apply_iterative_snap_rounding()` ? cc @MaelRL > > > > > > I do not like an `apply_` prefix. Did you have a look...
> > What do you think of `apply_iterative_snap_rounding()` ? cc @MaelRL > > OK, but I also meant the function `snap_polygon_soup()`: even if it's internal, best to still avoid naming...
``` /Users/magritte/cgal_root/CGAL-6.1-Ic-91/include/CGAL/Polygon_mesh_processing/internal/snap_polygon_soup.h:138:13: warning: unused variable 'pm' [-Wunused-variable] /Users/magritte/cgal_root/CGAL-6.1-Ic-91/include/CGAL/Polygon_mesh_processing/internal/snap_polygon_soup.h:136:9: warning: unused type alias 'GT' [-Wunused-local-typedef] /mnt/testsuite/include/CGAL/Polygon_mesh_processing/internal/snap_polygon_soup.h:223:5: warning: this 'else' clause does not guard... [-Wmisleading-indentation] ``` and PMP examples fully red [https://cgal.geometryfactory.com/CGAL/testsuite/summary-6.1-Ic-91.html?package=Polygon_mesh_processing_Examples](here)
PMP test/examples are fully red. See for example [here](https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.1-Ic-145/Polygon_mesh_processing/TestReport_lrineau_Ubuntu-Latest-CXX11.gz)
Successfully tested in CGAL-6.1-Ic-155
Successfully tested in CGAL-6.1-Ic-170
Successfully tested in CGAL-6.1-Ic-184
Successfully tested in CGAL-6.2-Ic-66