Sébastien Lorber

Results 1472 comments of Sébastien Lorber

I see now 🤪 thanks for clarifying. The markdown page content has changed from smaller to taller. So I'm going to move my comment here and remove it from the...

I'd rather have an updateHistory breaking change instead of duplicating fields Note it seems looking up for the git history might have performance implications, we can try this on our...

This command does not seem too slow to run locally: `git log --format=%ct,%an,%ae` 🤷‍♂️ but it's hard to tell for a lot of files. Maybe we should first write a...

> Isn't this data tree-shakable if unused? If this is imported/required it won't be tree-shaked even if it's not rendered IE if it's part of docs metadata it will add...

@jodyheavener do you want to do some edits? Otherwise I'll try to complete and merge it

🤯 this feature is full of little edge cases to consider. Still WIP, but it's progressing. I created a better docs dogfood dataset here, and it works nicely: https://deploy-preview-8004--docusaurus-2.netlify.app/tests/docs/tests/visibility/ There...

Almost ready to merge! Until I update docs + PR description, you can give it a locally with `SIMULATE_PRODUCTION_VISIBILITY=true yarn start:website` And these deploy preview dogfood cases: ## Blog -...

PR is good to merge! That wasn't an easy one 🤪 tons of little edge cases to consider.

We'll support custom Navbar Items in the future and also structured the code so that you can already do this yourself today with swizzle (see https://github.com/facebook/docusaurus/pull/7231) Agree we don't have...

> @slorber I never understood why the type: "docVersion" item exists. Can its to be made reactive? Probably not very useful, but it's just a simpler form of the version...