Sébastien Lorber

Results 1472 comments of Sébastien Lorber

yes we definitively want an eslint plugin 👍

For reference Gatsby recently added support for TS config files. That's worth studying their solution for the final implementation: https://github.com/gatsbyjs/gatsby/discussions/34613 I also found this interesting: https://github.com/egoist/bundle-require

> @slorber why does CI fail when I added styles for the component The CI says it: you just added an extra `!` in the tryAgain button label, and we...

I have one concern with such change, because we should probably have distinct logic for 2 cases: - slug inferred from the FS structure: yes we want to failsafe and...

> So if you have a page with slug /doc(1), it's actually served at /doc1 But is it the case with Gatsby / Next.js / Remix too? that's worth double-checking...

Quick StackBlitz repro link: https://stackblitz.com/github/fvsch/docusaurus-use-color-mode-stale-value?file=src%2Fcomponents%2FColorModeTest%2Findex.js --- Agree there is likely a React hydration problem. ```js const getInitialColorMode = (defaultMode: ColorMode | undefined): ColorMode => ExecutionEnvironment.canUseDOM ? coerceToColorMode(document.documentElement.getAttribute('data-theme')) : coerceToColorMode(defaultMode); const...

I'll probably fix this as part of the React 18 upgrade, as we'll be able to see hydration error messages that I would have to fix one by one to...

The problem is that we are trying to add an implicit search bar by default (ie not configured through `themeConfig.navbar.items`). When user does not want search, it does not make...

There's no good solution to this problem in React. I don't want to introduce hacky workarounds in our theme when there's a clear elegant solution: be explicit and avoid rendering...

Hi @alexandrebodin , happy to see Strapi using Docusaurus (as I'm also French :p) At first sight your issue to me is due to monorepo hoisting and using multiple versions...