Elizabeth Cox
Elizabeth Cox
@eapache Yes, the actual timeout option is mostly a convenience. I'm primarily interested in getting the last returned error to bubble up. You could argue that swallowing that error and...
Alternatively, if you are okay with the `WithTimeout` option, we could do something like this: ``` if err := r.sleep(ctx, timer); err != nil { // Timeout in effect, timeout...
@evanphx , I have not read through this entire thread, but I believe your change suggested by this PR does not take into account the `force_keep_alive` var in the request's...
@schneems This is 100% my understanding as well: > - Connection C makes a request and is stuck waiting in the reactor or on the TCP socket. > - Thread...
I believe the best way to ensure requests are handled in order and minimize queue time is to set `max_fast_inline=1` and return the client to the reactor at the end...
@amitsaxena > They also explicitly disable keep-alive for communication between Heroku router and dynos/puma as mentioned here: I'm working on the [new Heroku router](https://devcenter.heroku.com/articles/heroku-runtime-router-2-0), and this issue actually presented and...
Some more investigating this morning has led me to believe that even if you configure `max_fast_inline=1`, that is not a bullet-proof way to force connections to close. It's still possible...
This doesn't address the concern about keeping connections open while still serving requests in order, but think it's a worthy addition: https://github.com/puma/puma/pull/3496
Thanks @MSP-Greg! I'll take a look shortly. Also, does anyone know in what version we could expect the `enable_keep_alives` option to be released? Thanks