Samuel Leweke
Samuel Leweke
Some person in the forum successfully compiled on M1 and Raspberry Pi: https://forum.cadet-web.de/t/installation-issue-on-macos/567/18 Also, the CI still works (see, for example, https://github.com/modsim/CADET/actions/runs/8833714916/job/24253686970) with the `macos-14-arm64` image.
> I think the issue was that `setSparsityPattern()` is called in `configureModelDiscretization` and needs `_exchangeMatrix` to be defined. Well, then don't call it at this point 😛 It makes more...
General remarks: * Please use consistent indentation (tabs?). * What about some unit tests (e.g., analytic Jacobain vs. finite differences)?
I've moved the computation of the WENO coefficients from the `residualLiquidImpl()` to outside the class. As the coefficients only depend on the `_binSizes`, we can compute them once at configuration...
There were some bugs (mostly copy & paste), as well as a conceptual problem: > Maybe it's because of the 'skipConfig' flag? Indeed, that was the case. The validation code...
Splines look really weird:  Note that the formula for the `j`-th spline piece is: ``` s_j(t) = const_j + (t - breaks_j) * (lin_j + (t - breaks_j) *...
Can we collect the equations to be implemented here? This way, it is easier for someone who wants to actually do it.
Thanks for the analysis and suggestion. I generally agree. > Since the parameters themselves also have the suffices `_bulk`, `_liquid`, and `_solid`, we might simply unify the parameters reaction_model_bulk, and...
Also relevant: People from RWTH Aachen use a similar method called [NIXE](https://git.rwth-aachen.de/avt.svt/public/nixe), see also [Lotz et al. 2015](https://doi.org/10.1016/j.procs.2015.05.237) and [Hannemann et al. 2012](https://doi.org/10.1016/j.procs.2010.04.033). It is based on the code `SEULEX`,...
Some more ideas: * Dynamic iteration / waveform relaxation / co-simulation: Each unit operation has its own time-stepping with its own step-size. This allows to use the method best suited...