Sleepy Mole
Sleepy Mole
**Describe the problem/challenge you have** When there are multiple volume groups on a node, the lvm-driver always creates volume on the first volume group if possible.It seems this is expected...
We have implemented [rpcerror](https://github.com/pingcap/tiflow/tree/master/engine/pkg/rpcerror) to make it easier to handle errors from gRPC calls in a uniform way. It's no need to explicitly define the error in the response structures....
### What did you do? ``` go test github.com/pingcap/tiflow/engine/pkg/election ``` ### What did you expect to see? Test pass. ### What did you see instead? `ResignLeader` may return `record conflict`...
### What problem does this PR solve? ### What is changed and how does it work? ### Code changes - [x] Has Go code change - [ ] Has CI...
Some interfaces defined in the package support only comparable types. sets.Set ```go type Set[T comparable] interface { Add(elements ...T) Remove(elements ...T) Contains(elements ...T) bool containers.Container[T] // Empty() bool // Size()...
Close https://github.com/emirpasic/gods/issues/243. Some data structures support custom comparators. In these cases, the generic type constraint does not need to be comparable. This PR removes the unnecessary comparable type constraints from...
Run benchmark ```bash cd storage go test -bench=BenchmarkTxn_Commit_P512 ``` Output ``` transaction_test.go:193: Error Trace: /home/xyj/Projects/zgraph/storage/transaction_test.go:193 /home/xyj/Projects/zgraph/storage/benchmark.go:788 /home/xyj/Projects/zgraph/storage/asm_amd64.s:1594 Error: Should be true Test: BenchmarkTxn_Commit_P512 ```