pingcap
br: support ebs snapshot
What problem does this PR solve?
What is changed and how does it work?
Code changes
- [x] Has Go code change
- [ ] Has CI related scripts change
Tests
- [ ] Unit test
- [ ] E2E test
- [ ] Manual test
- [ ] No code
Side effects
- [ ] Breaking backward compatibility
- [ ] Other side effects:
Related changes
- [ ] Need to cherry-pick to the release branch
- [ ] Need to update the documentation
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.
br: support ebs snapshot
[REVIEW NOTIFICATION]
This pull request has been approved by:
- csuzhangxc
- fengou1
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
Codecov Report
Merging #4698 (d12420c) into master (c781497) will increase coverage by
3.87%. The diff coverage is50.98%.
Additional details and impacted files
@@ Coverage Diff @@
## master #4698 +/- ##
==========================================
+ Coverage 62.29% 66.16% +3.87%
==========================================
Files 206 216 +10
Lines 25143 26683 +1540
==========================================
+ Hits 15662 17656 +1994
+ Misses 8156 7600 -556
- Partials 1325 1427 +102
| Flag | Coverage Δ | |
|---|---|---|
| e2e | 39.56% <13.07%> (?) |
|
| unittest | 61.25% <52.38%> (-0.21%) |
:arrow_down: |
@WizardXiao: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.
In response to this:
LGTM
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
@fengou1: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.
In response to this:
currently, my validation shows the PR is good enough to go.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
@WangLe1321: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
@csuzhangxc: /merge in this pull request requires 2 approval(s).
In response to this:
/merge
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
This pull request has been accepted and is ready to merge.