Stephen L. De Rudder

Delay creation of `std::unique_ptr thread_pool;` in DefaultContext struct. Only call `instantiate_thread_pool()` when required. Creating the thread pool is what causes problems when run from DllMain during DLL_PROCESS_ATTACH on Windows platforms....

Its great that you use Doxygen but you need to do something for the users of your API and for the end users that will want to configure the logging...

ThreadPool::~ThreadPool() Windows Deadlock Posible Solution

4

The ThreadPool destructor will still deadlock when log4cplus::Initializer initializer; is at top of main if main starts a thread and in that thread exit(2); is called. The following will fix...

Please consider making cross platform exceptions easy to catch

1

In the following code, reading the content requires catching std::system_error then checking for std::net::error::eof in the code() call. It would be nice if most (if not all) errors could be...

Should the type be uint8_t instead of size_t for serialize_v1p(...) in srv_state.hxx line 133

1

https://github.com/eBay/NuRaft/blob/188947bcc73ce38ab1c3cf9d01015ca8a29decd9/include/libnuraft/srv_state.hxx#L133 or if it really needs to be size_t then maybe `static_cast()` around `bs.put_u8(version);` VS 2022 is complaining about it. Thanks, SLDR

### Environment Info This is happening with Asio V1.29.0 (non-Boost) on Windows 10. I have also tried using the code from master and it still causes the crash. I compile...

When creating a DLL none of the functions are exported. I also set the version in meson.build to "1.00". SLDR

Update meson.build to add install support

1

The meson.build doesn't have the ability to install with `meson install` command. By adding install support to meson.build the meson install command will work. This also will support the creation...