Sébastien Launay

Results 11 comments of Sébastien Launay

I believe there are two issues discussed here with similar outcomes. ### Default configuration of the AsyncProducer can lead to long delays By default the `AsyncProducer` has retries and backoff...

The `SyncProducer` uses the `AsyncProducer` under the hood so this is likely a duplicate of #2150. When the issue occurs, do you also see a record with `null` key and...

@shweta-fourkites if you are using Samara `1.31.1`, this is likely a duplicate of #2129 (producer deadlock) that was fixed in #2133. The fix is available in `1.32.0` released recently but...

@shweta-fourkites I was able to reproduce what looks like #2150 yesterday. There seem to be a race condition during retries where: - a `brokerProducer` is shutting down after getting an...

Thanks a lot for testing the fix @shweta-fourkites and confirming that the issue is fixed. I'm not a maintainer for Sarama but I believe the goal is indeed to have...

Line 560 for `1.32.0` does not seem to dereference a `brokerProducer`: https://github.com/Shopify/sarama/blob/9baf7a651a68631e143039fafd7a7bb13ebdceca/async_producer.go#L560 Would you be able to post the panic trace, confirm the version and ideally provide some Sarama logs?...

@crcms if you can share the panic trace that would go a long way.

Thanks @crcms, the stack points us to line `618` for the `nil` derefencing vs line `560`: https://github.com/Shopify/sarama/blob/9baf7a651a68631e143039fafd7a7bb13ebdceca/async_producer.go#L615-L619 One scenario that would lead to the `brokerProducer` being `nil` prior to calling...

Version `1.29.5` fixed the issue by applying @jsight suggested code change: `Build finished. 132 tests run, 0 skipped, 0 failed.` I believe this ticket can be closed now.

@jameschao what kind of test report are you using in your job?