Dhruv

Results 38 comments of Dhruv

@brianmcarey Hi ! I'm thinking of working on this, are the changes only to be made in the file section that you've linked ? Or is it all the .build...

@brianmcarey Oh sure, thanks for letting me know ! Also I apologize if this is not the correct place to ask this but can you suggest a good starting point...

@Swpn0neel I have opened a PR for the same, can you please take a look ?

Hi @Peefy , I'd like to work on this issue but I'm not really used to the Nix configs. To get some clarifications, this is the only part from the...

@mviswanathsai I've added these tests for storage and replica specs Can confirm that these pass when I add the `+kubebuilder` validations and fail otherwise ``` --- PASS: TestGatedFeatures (159.61s) ---...

![image](https://github.com/user-attachments/assets/b5b1e32b-8018-4e39-9aeb-1645d4180c8e) ![image](https://github.com/user-attachments/assets/0504a325-c0c7-4fcc-8e05-3a66684cb989)

@mviswanathsai if this is gtg, lets get this merged first, then I'll add the other PR testcases under the same table.

> It also requires a validation inside [globalConfig](https://github.com/prometheus-operator/prometheus-operator/blob/main/pkg/alertmanager/amcfg.go#L1726) to ensure alertmanager >= v0.28.0 https://github.com/prometheus/alertmanager/pull/3600/files Thanks for pointing out the changes @heliapb ! A little clarification on this part, we need...

@slashpai would you mind taking a look as well ?

> > Also you need to add test to [amcfg_test.go](https://github.com/prometheus-operator/prometheus-operator/blob/main/pkg/alertmanager/amcfg_test.go) > > Hi @slashexx thanks for the work thus far I think we are close to be done, still as...