Stephane Landelle

Results 214 comments of Stephane Landelle

Sorry, I don't get what your changes are supposed to fix. Could you elaborate please? And yes, please add tests that fail without your changes.

@Diagoras I don't use Gitter, and am almost never connected on IRC. Best way is Gtalk (slandelle at gatling dot io).

Hilarious. `InetAddress.getByName("localhost").getCanonicalHostName()` return `127.0.0.1` with JDK8 and `localhost` with JDK11. I would say JDK8 behaviour is wrong, but then, I have no idea what the expected behavior in the context...

Yeah, actually I think @twz123 is right and this would also break for people who spawn and shutdown AHC instances at runtime without stopping the application :(

Frankly, I'm not fond of this implementation. Netty is just everywhere nowadays. People using Netty for multiple components are probably at least 50% of AHC users, eg: * server side...

There's value in naming the (single) timer thread differently so it can be told appart from the IO threads. AFAIK, the only way to achieve the same thing would be...

Hi @mchernyakov Yes, feature request is still open, please feel free to contribute.

I'm able to reproduce. I slightly changed your test: ```java private void testMultithreadedGet_inner(int ioThreads, int requestThreads) throws Throwable { final int contentLength = 1024 * 1024; final byte[] payload =...

Looks like the way to go. Contributions welcome :)