Kenneth Skovhus comments

Results 254 comments of


                                            Kenneth Skovhus

Ava's test.throws accepts Promise value

Thanks!

Ava contexts not transformed

Thanks for reporting this. Let me know if you would like to try to fix it. : )

tape: keep custom expect messages

I'm not convinced we should support this use case as isn't supported natively by Jest and requires the custom `jest-expect-message` dependency (18K weekly downloads compared to Jest with 14M weekly...

Broken conversion from tape tests

Thanks for reporting this. It seems we are not handling that corner case correctly. : / Let me know if you have any suggestions on how to fix this. And...

Add aliases for [email protected] in the transformer

Hi @Justkant Thanks for reporting this. I thought we already did this... Do you have a specific case that is not transformed?

Add aliases for [email protected] in the transformer

@Justkant thanks. So `toContain` should already be supported... Did you get an error after using `jest-codemods`?

Add aliases for [email protected] in the transformer

@Justkant is this not relevant anymore? Else let us keep it open. : )

Add aliases for [email protected] in the transformer

Sure. I'm happy it was useful to you! : ) Let me know if you find other issues or have ideas for improving the codemod.

Implement missing should.js transformations

Let me know if you remember any examples of this.

Mocha migration this.timeout and this.slow

@pornel thanks for reporting this. Not sure what this should be changed to. Modifying global jasmine timeout probably isn't what the user want... So I guess adding a warning would...