jest-codemods icon indicating copy to clipboard operation
jest-codemods copied to clipboard

Implement missing should.js transformations

Open skovhus opened this issue 6 years ago • 2 comments

When converting webpack to Jest, jest-codemods failed on converting the should.js construct oneOf.

Let us go over the should.js transformer and see if there are more matchers that I missed.

  • [ ] expect(typeof id).to.be.oneOf("number", "string")
  • [ ] figure out if there are more matchers that are not supported by jest-codemods

skovhus avatar May 14 '18 19:05 skovhus

I remember there were also quite a few false positives (where changes were made to code that shouldn't have been touched by the codemods).

niieani avatar May 14 '18 20:05 niieani

Let me know if you remember any examples of this.

skovhus avatar May 15 '18 06:05 skovhus