Simon Kobyda

Right, so this looks good and I like it. I'm thinking how to split this out into separate items. My idea is: 1. I would perhaps first start with combining...

> > Would be combined into one dialog, something like this? > > Yes, correct. Something like that. > > That dialog should be improved (the number entries shouldn't be...

Okay, I can now see that CPU redesign would need some time, and since the new design will not work without all cpu details in a single modal, I'll start...

Just to confirm, you have a setup of Windows guests running under QEMU-KVM, just like in the blog you linked, right? Anyway, currently, cockpit doesn't support configuring any CPU enlightenments...

This is currently blocked on https://github.com/virt-manager/virt-manager/pull/311 , as it fails https://logs.cockpit-project.org/logs/pull-394-20211004-110348-b16aad72-fedora-34/log.html#21-2

There is already a release in fedora 36 and ubuntu 2204. I can get going with this PR :)

This now passes on all distros where virt-xml (virt-manager package) is >= 4.0 . I wonder if I should just keep this PR blocked until it's released in the other...

> @skobyda this looks still blocked at least for rhel-8-8, as we still update that, but seems like virt-xml is not updated there. Yeah I updated this PR last week...

> This is probably unblocked by now? No idea, let's re-trigger

> This is probably unblocked by now? Nope, old version of virt-xml is still present on centos-8-stream and rhel-8-*, so this PR will not get merged until we stop supporting...