cockpit-machines icon indicating copy to clipboard operation
cockpit-machines copied to clipboard

Published 20 hours ago • verified publisher icon cockpit-project

Introduce virt-xml into disk APIs

Open skobyda opened this issue 3 years ago • 14 comments

skobyda avatar Sep 24 '21 13:09 skobyda

Fixed the filesystem, disks still broken: https://logs.cockpit-project.org/logs/pull-394-20210924-130035-1e3d9861-fedora-34/log.html

KKoukiou avatar Sep 27 '21 15:09 KKoukiou

This is currently blocked on https://github.com/virt-manager/virt-manager/pull/311 , as it fails https://logs.cockpit-project.org/logs/pull-394-20211004-110348-b16aad72-fedora-34/log.html#21-2

skobyda avatar Oct 08 '21 11:10 skobyda

The fix landed in upstream virt-manager 26 days ago, but not released yet AFAICS.

martinpitt avatar Feb 14 '22 07:02 martinpitt

There is already a release in fedora 36 and ubuntu 2204. I can get going with this PR :)

skobyda avatar Apr 07 '22 07:04 skobyda

This now passes on all distros where virt-xml (virt-manager package) is >= 4.0 . I wonder if I should just keep this PR blocked until it's released in the other distros too, or just write an exception/antipattern for it

skobyda avatar Sep 07 '22 10:09 skobyda

@skobyda this looks still blocked at least for rhel-8-8, as we still update that, but seems like virt-xml is not updated there.

KKoukiou avatar Jan 31 '23 11:01 KKoukiou

@skobyda this looks still blocked at least for rhel-8-8, as we still update that, but seems like virt-xml is not updated there.

Yeah I updated this PR last week to see where it still continues to fail. I'd not try to push this until every distro gets new version of virt-xml

skobyda avatar Feb 02 '23 12:02 skobyda

This is probably unblocked by now?

KKoukiou avatar Oct 13 '23 06:10 KKoukiou

This is probably unblocked by now?

No idea, let's re-trigger

skobyda avatar Oct 13 '23 10:10 skobyda

This is probably unblocked by now?

Nope, old version of virt-xml is still present on centos-8-stream and rhel-8-*, so this PR will not get merged until we stop supporting those distros

skobyda avatar Oct 13 '23 10:10 skobyda

@martinpitt, @KKoukiou, what's the point of using virt-xml? Does it augment the XML with its own knowledge of best defaults? Otherwise this looks like a step back to me, in the JSON > XML > CSV hierachy. (I think we need to worry about quoting when constructing the virt-xml invocations, for example.)

mvollmer avatar May 14 '24 10:05 mvollmer

Please reopen if this is still wanted.

mvollmer avatar May 14 '24 10:05 mvollmer

@mvollmer I am severely out of context on this repo but the virt-xml direction was desired as it picks up correct defaults when attaching devices and removes a lot of custom logic from our side. I dont have examples right now handy.

KKoukiou avatar May 14 '24 10:05 KKoukiou

but the virt-xml direction was desired as it picks up correct defaults when attaching devices and removes a lot of custom logic from our side.

Ok, convinced.

mvollmer avatar May 20 '24 12:05 mvollmer