tcr
tcr copied to clipboard
skmgoldin
A generic token-curated registry
It would reduce cognitive overhead for users if the exitPeriodLen was just the exitTimeDelay value. I don't think it needs to be overcomplicated. We already have a bunch of complicated...
The challenge function has the following check: `require(appWasMade(_listingHash) || listing.whitelisted);` I believe the 2nd half of the conditional (`listing.whitelisted`) is unnecessary, as a whitelisted listing will always have an `appExpiry...
* Create `ChallengeInterface` so that different challenges can easily plug into the registry * Create `PLCRVotingChallenge` contract * Create `PLCRVotingRegistry` which extends `Registry` and points to `PLCRVotingChallengeFactory` to create a...
I get the following error when trying to migrate the contracts. I haven't been able to figure out why this is happening. ``` Running migration: 4_parameterizer_factory.js Deploying ParameterizerFactory... ... 0xa2cf44175fc7bd144394cdd2e7cb859f10f5df0322e347fa6dd7f6d3287f9135...
We fire an event for initializing exits, so users can detect this state, but isWhitelisted should detect it as well and return false for listings which have initiated an exit....
truffle exec scripts/deploy_proxies.js failed silently. ``` Using network 'development'. RegistryFactory: 0x23e84570f7b28ad0d5e5545d398009194a8734f3 Deploying proxy contracts... ``` did a truffle debug and got the following error ``` Parameterizer.sol: 248: @param _challengeID the...
- Delayed exits - Removing salts for claiming rewards - Multi-functions
Presently, `Registry.sol` imports `Parameterizer.sol` in its entirety, but only calls the function `get(string _name)`. You can save gas and storage space by using a `ParameterizerInterface.sol` in `Registry` ```solidity interface ParameterizerInterface...
1. `determineReward`: gets the number of tokens for the winning party of a challenge (Applicant or Challenger, not Voter) How about `challengeWinnerReward`? (same implementation as the now deprecated #10) ---...
