tcr icon indicating copy to clipboard operation
tcr copied to clipboard

Require check in challenge function has unnecessary part of conditional

Open nickreynolds opened this issue 6 years ago • 0 comments

The challenge function has the following check: require(appWasMade(_listingHash) || listing.whitelisted);

I believe the 2nd half of the conditional (listing.whitelisted) is unnecessary, as a whitelisted listing will always have an appExpiry > 0.

nickreynolds avatar Dec 07 '18 16:12 nickreynolds