John Molakvoæ

> With this I suppose we can remove > > https://github.com/nextcloud/server/blob/cfc1c21a80c90f8668846ed528f7b4355cbb6c24/apps/theming/lib/Controller/ThemingController.php#L376 > > again? (I must admit using the primary color as background-color is a misuse) That's not related to...

> > That's not related to this pr, is it? > > Not really, no. Could be done in a follow-up I suppose... [image](https://user-images.githubusercontent.com/42591237/166149425-614701fd-0f55-4bfc-bdf0-0b8e4eada25c.png)  Ah! But it's also kinda...

> @skjnldsv sorry for asking but is this still needed? If yes, would you mind rebasing and resolving conflicts? Otherwise I could try if you want :) Feel free to...

Rebased for you here is how I did it 1. `git reset --hard 92477bc018785eea473cf0e471437add09e3bc3e`, to reset to the last commit before the last three merge you had 2. `git rebase...

> @skjnldsv what happens if you still send basic auth for "[dev.domain.com/public.php/dav/files/Y9Hc4SPqg564gid](https://dev.domain.com/public.php/dav/files/Y9Hc4SPqg564gid)" ? will it then try to look for a folder "Y9Hc4SPqg564gid" inside the share ? just to double...

Finally all green! Ok everyone, this is ready for revew! This will be a great enhancement for 29! Also includes proper phpunit testing! :rocket:

Failure related to https://github.com/nextcloud/server/pull/35547 It seems `hasImage` returns true despite the background being deleted https://github.com/nextcloud/server/blob/9597036b7280940c834c623de4bb1716cb6fcf4a/apps/theming/lib/Themes/CommonThemeTrait.php#L104 Investigating

This actually goes deeper, this comes from https://github.com/nextcloud/server/pull/30624 Where we remove the check of the file existing, but to remove the background, we set the mime to 'backgroundColor'. So the...

> cypress failure ? or needs rebase / restart ? Need me to find time to dive into this again :see_no_evil: 

Yes we should but I don't have time for this unfortunately :/