server
server copied to clipboard
Support theme meta w3c standard
https://html.spec.whatwg.org/multipage/semantics.html#meta-color-scheme
With this I suppose we can remove https://github.com/nextcloud/server/blob/cfc1c21a80c90f8668846ed528f7b4355cbb6c24/apps/theming/lib/Controller/ThemingController.php#L376 again? (I must admit using the primary color as background-color is a misuse)
With this I suppose we can remove
https://github.com/nextcloud/server/blob/cfc1c21a80c90f8668846ed528f7b4355cbb6c24/apps/theming/lib/Controller/ThemingController.php#L376
again? (I must admit using the primary color as background-color is a misuse)
That's not related to this pr, is it?
That's not related to this pr, is it?
Not really, no. Could be done in a follow-up I suppose...
That's not related to this pr, is it?
Not really, no. Could be done in a follow-up I suppose... image
Ah! But it's also kinda related to the feature, sorry I misunderstood :) I'll see that after the weekend :see_no_evil:
@skjnldsv sorry for asking but is this still needed? If yes, would you mind rebasing and resolving conflicts? Otherwise I could try if you want :)
@skjnldsv sorry for asking but is this still needed? If yes, would you mind rebasing and resolving conflicts? Otherwise I could try if you want :)
Feel free to dive at it :)
@skjnldsv sorry for asking but is this still needed? If yes, would you mind rebasing and resolving conflicts? Otherwise I could try if you want :)
Feel free to dive at it :)
Rebased and fixed conflicts! :)
This PR changes focus-visible
styles for me.
I have a dark system theme and a light Nextcloud theme. With this PR, I have
<meta name="color-scheme" content="light dark">
Is light dark
an expected value? Why dark
if I have the light theme?
With light
- outline is the same as it was before this PR: