Hartley McGuire

Router implementation alternatives

1

The current implementation of the router (depending on parsing the current DOM into virtual nodes) seems like not very good practice and is definitely not declarative. I have two potential...

Better adhere to XDG specification

3

[Spec for reference](https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html) Currently, any package that uses `update-notifier` results in an `update-notifier-.json` being put in `$XDG_CONFIG_HOME`. As someone who symlinks my `$XDG_CONFIG_HOME` into my dotfiles repository, this leads to...

bundler: optimize gemfile parsing

7

# Summary After profiling `FileParser#parse` for bundler, I found that the ruby Parser was extremely hot. The same Gemfile was being parsed twice for each dependency, when it only needed...

``` > [email protected] build /.../prerender-loader > microbundle -f cjs --no-compress --external all Error: Plugin 'jsx' not found ``` I'm interested in creating a PR to not stub out `requestAnimationFrame`, as...

### Motivation / Background Previously, when upgrading from 6.0 to 6.1, the EventedFileWatcher configuration is always uncommented because --skip-listen is never set during app:update. ### Detail This commit fixes that...

### Motivation / Background Similar to 753633abdfc72743419ba86ef4981679098365e5 and fa6067d, but for Action Mailbox ### Additional information Ref #42378 Ref #42657 I tried to add a test similar to the one...

Deprecate implicit convertion of Duration

7

### Summary The presence of method_missing on Duration can lead to some very confusing behavior: ```ruby 1.year.days # => 31556952 Days ``` Methods to convert from duration to a specific...

Fix adding sprockets-rails during upgrade (7-0-stable)

1

### Summary The previous strategy for adding `sprockets-rails` did not work for two reasons: - the regular expression would only match `require("rails/all")` (with parentheses) and not `require "rails/all"` - adding...

Fix all 'assigned but unused variable' warnings

4

- The variables in content_location_parser appear to have been copied from content_disposition_parser but are unused - Ragel seems to always generate a useless testEof variable. The `if false` trick is...

### Summary Previously, requiring parsers emitted a number of unused variable and unreachable statement warnings. The unused variable warnings are simple to fix (see skipkayhil/mail@8dd1655dc4628e34d9d654a1526bac7cd9513252), but the unreachable statements do...