Hartley McGuire

Results 77 comments of Hartley McGuire

I found that `:unknown` service is tested in Active Storage: https://github.com/rails/rails/blob/d51b17184932f54d60e2098fccbdcceaa76ba753/activestorage/test/models/attached/many_test.rb#L890-L898 That's not _really_ what we want to be testing but it may work okay? It's also possible that Active...

I'll add that there is one case I found that I'm not sure of a good way to fix: non-sprockets railties are skipped (so `sprockets/railtie` is required and not `rails/all`)...

It looks like [Sequel](https://sequel.jeremyevans.net/rdoc/classes/Sequel/Dataset.html#method-i-select_append) uses `select_append` or `select_more` and [ROM](https://rom-rb.org/4.0/learn/sql/queries/#appending-more-columns) also uses `select_append`. It may be worth using `select_append` just for consistency

I think instead of `--colorized` I would love to see a more general `--format` option, and an API to register formatters. Then applications/gems could define new formatters and it wouldn't...

> @skipkayhil By implementing what you're saying, `--expanded --colorized` would actually colorize the "expanded" format, right? > > The current `--colorized` really looks like both "colorized" AND "justified". > >...

I had that thought as well. Just running Active Support tests the following methods are used: `abs` is used when finding time zones, but it could easily be rewritten to...

@matthewd updated to implement all of the methods we discussed, I still need to write more tests and documentation but figured I'd ask for another round of feedback first >...

Finally got back around to this, updated to add more deprecations and tests for the new methods. > I think `*(Duration)` is silently treating `other` as Just A Number, so...

I can create a PR for this, do you have a recommended way to do it? The simplest is probably passing in the new configPath to configstore.