Evgenii

Results 39 comments of Evgenii

I need help from core team to setup github checks (tests, linters) for freebsd os. And seems currents test required root to run + do not cleanup all created interfaces...

Actually running tests locally is very risky. You MUST run them only in isolated VM. I noticed tests changed system state and keep it inconsistent. For example /etc/resolv.conf

I have added FreeBSD support to Netbird client, and from what I know, routing on FreeBSD untested, and currently 3 routing related e2e tests completely disabled for FreeBSD. Take a...

`TestRouting` failed because can't cleanup route `10.0.0.0/8` ``` time="2024-08-06T21:15:16Z" level=info msg="using userspace bind mode" time="2024-08-06T21:15:16Z" level=info msg="create tun interface" time="2024-08-06T21:15:16Z" level=info msg="assign addr 100.64.0.1 mask 0xffffff00 to utun100 interface" time="2024-08-06T21:15:16Z"...

`TestAddRemoveRoutes` ``` time="2024-08-06T21:26:48Z" level=info msg="using userspace bind mode" time="2024-08-06T21:26:48Z" level=info msg="create tun interface" time="2024-08-06T21:26:48Z" level=info msg="assign addr 100.65.75.2 mask 0xffffff00 to utun530 interface" --- FAIL: TestAddRemoveRoutes (0.02s) --- FAIL: TestAddRemoveRoutes/Should_Add_And_Remove_Route_100.66.120.0/24...

Found the reason of failed `TestAddRemoveRoutes` https://github.com/netbirdio/netbird/blob/bcce1bf18474e68744d81a6b05b8a32e901ae771/client/internal/routemanager/systemops/systemops_generic.go#L381 It was added in https://github.com/skillcoder/netbird/commit/370eecfa908c208f8306fafd7c3800598cb6de75 to fix routing on FreeBSD, without it routing was not working properly, but during refactoring it 2 return...

But now without this workaround tests passed.

And seems `TestGetNextHop` also fixed after these changes.

Only `TestRouting` left, and it's still failed with the same logs. ``` Error: Received unexpected error: failed to delete route for 10.0.0.0/8: route cmd retry failed: exit status 1 Test:...