Kapralov Sergey

Results 27 comments of Kapralov Sergey

@victornoel the main purpose I wrote this post is to prove that there is nothing good in checked exceptions for "Elegant Objects" approach. And Cactoos IMO is very representative example...

@martin-robo Check [this](http://disq.us/p/1wje1zf) thread. In general, I'd recommend also to go through in-comment discussions there, because topics you've raised were already touched there in some way or the other. >...

@martin-robo > For now I'm a bit lost frustrated because I already wrote thousands of lines of code with cactoos and now a core principle is being turned upside down...

@victornoel Theoretically type of exception can matter for rather cosmetic scenarios of how the stack trace will eventually be shown to developers. Like, custom exception's name can give some hint...

@0crat status

@0crat waiting https://github.com/jcabi/jcabi-xml/issues/143

@uweschaefer +1, stumbled exactly on the same thing.

Another event that failed: ``` { "action": "closed", "number": 22, "pull_request": { "url": "https://api.github.com/repos/pragmatic-objects/oo-equivalence/pulls/22", "id": 311110994, "node_id": "MDExOlB1bGxSZXF1ZXN0MzExMTEwOTk0", "html_url": "https://github.com/pragmatic-objects/oo-equivalence/pull/22", "diff_url": "https://github.com/pragmatic-objects/oo-equivalence/pull/22.diff", "patch_url": "https://github.com/pragmatic-objects/oo-equivalence/pull/22.patch", "issue_url": "https://api.github.com/repos/pragmatic-objects/oo-equivalence/issues/22", "number": 22, "state": "closed",...

Root cause: events above occurred in repositories, located at `pragmatic-objects` github organisation. And in events handler, there is `OpIgnoringUnprivildgedEventSender` decorator, which cuts out events, happened from actions of non-owner users....

> A PR may be merged but it doesn't necessarily mean it solved the issue... Since all issues are estimated at 30 mins, hard to imagine for me the one...