skaaptjop comments

Results 5 comments of


                                            skaaptjop

When passing user_data per documentation it does not handle undefined values

It is there for null but not undefined ``` function hashFunction(input){ if(input == null || isAlreadyHashed(input)){ return input; } return sha256Sync(input.trim().toLowerCase(), {outputEncoding: 'hex'}); } ``` One could rewrite that first...

When passing user_data per documentation it does not handle undefined values

Looks like this is resolved in[commit e4ebdf48fdfee975755614579e9664be7876a235]( https://github.com/facebookincubator/ConversionsAPI-Tag-for-GoogleTagManager/commit/e4ebdf48fdfee975755614579e9664be7876a235)

Added function to remove leading + from user_data.phone_number

This addresses #30

Events failing, test failing

Tests seem to be passing on latest commits

Webhook validation fails

Problem I believe might be here: https://github.com/sendgrid/sendgrid-python/blob/3e9d4efac5d652de81fb82ae38d256aad78c00d5/sendgrid/helpers/eventwebhook/__init__.py#L47 `key.verify` wants payload in bytes, not unicode string so why not just leave the payload in bytes the whole way through? Then there...