SJW

Results 9 comments of SJW

The remainder of cl_khr_subgroups functions that should be implemented for full support: * get_enqueued_num_subroups * sub_group_reserve_read_pipe * sub_group_reserve_write_pipe * sub_group_commit_read_pipe * sub_group_commit_write_pipe * get_kernel_sub_group_count_for_ndrange * get_kernel_max_sub_group_size_for_ndrange

> have you been able to try HF_Bert ? We use that for our tests. We will continue to debug this. I have some time now, will give that a...

@ptillet @Jokeren I believe these changes are ready for review and appreciate your feedback.

Most of the current feedback should be addressed, please verify. @Jokeren I am looking into exactly why the membar test changed.

@Jokeren regarding the membar test change: - Now the allocation correctly reuses the same buffer offset since all buffers on mutually exclusive - This causes membar to require a `barrier`...

> > Now the allocation correctly reuses the same buffer offset since all buffers on mutually exclusive > > Allocation is not a memory write or memory read. Hmm, that...

@ThomasRaoux @Jokeren , this should be just the alignment fix.

I did remove the `bufferStart` since it seemed unnecessary.

@antiagainst your request should be resolved. Please verify