Stephen Sadowski

This is still an issue. Figured it's just getting ignored. since there hasn't been a commit in 2 years.

https://www.example.com/api is not a valid server name, it is a complete URI. With that being said, '/' is an invalid character for a hostname, and this should be throwing an...

@Tronic It hasn't changed, but the internal documentation refers to it being used when host_name isn't present, which in itself is probably wrong. In reality there probably needs to be...

Note: Even though this is an exceptionally minor fix, I don't feel like this should be backported to 20.12LTS. 20.12LTS will sunset long before 3.12 is past alpha (and possibly...

I'll resurrect this, completely forgot about it.

In general, I'm giving this my +1. There's a lot to chew through here, but I understand the value. I'm hoping that @sanic-org/core-devs can review, and those who are better...

I'm putting my chop on this. I was satisfied with the walkthrough and the Q&A, and I think with tests passing as best as can be expected, I'm ready for...

Can you provide more context? Why wouldn't the following work? ```py external_host = request.headers.getone("X-Forwarded-Host", sanic.config.SERVER_NAME) external_scheme = request.headers.getone("X-Forwarded-Proto", "http") app.url_for('hello', _external=True, _scheme=external_scheme, _host=external_host) ``` It seems like the desire is...

So when testing this, the exception bubbles up and causes an ASGI lifespan error in both uvicorn and hypercorn. I'm not sure what the right process is to handle this...

Please provide a full stack trace, how you are running python (IronPython? WSL? something else? Are you using a dependency management tool? Virtualenv?) and if possible the banner that displays...