Sjoerd Talsma

Results 80 comments of Sjoerd Talsma

> Hi, I would like an option to ignore the cyclic package dependencies warning if that is possible. Thanks a lot. Kas @kasderooi Could you create a separate issue for...

See https://github.com/Kotlin/kotlinx.coroutines/issues/119

As I don't use Kotlin in production at this moment, I feel I would not be able to provide reasonable usecases for the tests to write.

Thank you for pointing this out. I feel some reluctance of 'clearing' values that were not part of this context, so maybe reverting to the context as it was before...

Although small and most applications having it on their classpath already, I still find the need to limit the number of dependencies for this library of greater importance. All you...

> Would you mind at least leaving this issue open? I suspect that libraries using this project will be eventually facing these issues. I don't mind at all, will leave...

Both in [TracedCallable](https://github.com/opentracing-contrib/java-concurrent/blob/master/src/main/java/io/opentracing/contrib/concurrent/TracedCallable.java) and [TracedRunnable](https://github.com/opentracing-contrib/java-concurrent/blob/master/src/main/java/io/opentracing/contrib/concurrent/TracedRunnable.java) any scope that gets activated is closed again after the operation. Could it be that there are places where scopes are _not_ closed properly? Which...

Since your `AutoFinishScope` behaviour is optional, could you please make sure not to introduce new runtime dependencies (such as opentracing-util from test to `provided` instead of runtime) ? You will...

Maybe it's an idea to split up _client_ and _server_ support as these both have very different dependencies? **edit** Just noticed my issue #16 :smile:

@objectiser Please be advised that there is currently no easy way to determine whether a `GlobalTracer` was registered or not. You always get its singleton instance from `GlobalTracer.get()`. I think...