java-concurrent icon indicating copy to clipboard operation
java-concurrent copied to clipboard

Adds support for AutoFinishScope

Open jam01 opened this issue 6 years ago • 2 comments

Adds support for AutoFinishScope by checking the type of ScopeManager and using a AutoFinishScope.Continuation when appropriate. Includes some tests.

jam01 avatar Sep 14 '18 23:09 jam01

Since your AutoFinishScope behaviour is optional, could you please make sure not to introduce new runtime dependencies (such as opentracing-util from test to provided instead of runtime) ?

You will have to take care of some gotcha's to make this work:

  1. Don't import any optional classes but use their fully qualified name (otherwise the import will throw linkage error when your class is loaded instead of when the optional class is actually needed)
  2. Catch and anticipate a linkage error (usually NoClassDefFoundError)

sjoerdtalsma avatar Sep 17 '18 11:09 sjoerdtalsma

What's the status of this PR?

jpkrohling avatar Apr 05 '19 08:04 jpkrohling