sjanel

No one to handle this issue ? It should at least be mentioned in the documentation.

I agree, at least mentioning it in the doc would be great. It's strange though that for other containers, this is not legal (`std::vector.insert()` for instance requires that iterators are...

> Thanks! It seems @falbrechtskirchinger is working in #3446 on similar issues - can you please check whether his adjustments go in the same direction? Thanks for your comment. I...

> > * Remove default value initialization, which does not seem to be used, such that union is valid > > * Made `iter_impl` copy construction default, such that it...

> Please update to the latest develop branch (we renamed some folders in #3462). Ok, done

Hi, no thoughts about this PR? Thanks

> Not that my opinion matters here but I had a look anyway, and I like it. smile > > Still, I think this would be even better if >...

> Hi, OK, [here](https://github.com/jupp0r/prometheus-cpp/pull/563) is the first extracted PR with move constructors.

Hello, can someone relaunch the builds please ? The errors do not seem to come from the PR.

> I generally understand the motivation behind this contribution but I would generally suggest opening an issue to discuss ideas this large, tip for the future :) > > There...