Eric Sivonxay
Eric Sivonxay
The changes look good so far. They make things more clear/transparent about what's happening. While this isn't being used much in our group at the moment, It's unclear to me...
These changes look good. Thanks for cleaning up this class, @mjwen!
I think @rdguha1995 is correct that this has to do with git. But I think the issue is dependent on how the user clones/pulls fireworks. I think this may arise...
I think that sounds reasonable. That would be behavior I expect from the comparison
I noticed this as well. I believe the offending lines are the following (the latter for serial running within a jupyter notebooks): https://github.com/materialsproject/maggma/blob/9e037d7349e531be7d5f05096815781ab6e8faa6/src/maggma/cli/__init__.py#L70-L71 https://github.com/materialsproject/maggma/blob/672c6aedc8af97029b14a73849b39a9c45988e96/src/maggma/core/builder.py#L127-L128 Not sure what's the best way...