Matt Martz

icon indicating a website link http://sivel.net/ icon indicating an email [email protected]

icon company @ansible @RedHatOfficial icon location San Antonio, TX icon location Ansible Core Engineering Architect and Technical Team Lead

Results 336 comments of Matt Martz

Address non-UTF8 module responses with `diff` in git module

Moving back to draft.

Jinja exception line numbers are incorrect

Tested in an upcoming change (`data_tagging`) that will be merged for 2.18: ``` File "/Users/sivel/projects/ansibledev/playbooks/82771/test2.j2", line 2, in template {% set foo, bar = none %} TypeError: cannot unpack non-iterable...

Including tasks with `first_found` fails to find files within same task directory

Caused by https://github.com/ansible/ansible/commit/a9919dd7f62c9efe17b8acaebf7c627606ae9f66

Unexpected exception while installing ansible galaxy collections via ansible-builder

This is caused by using an unsupported version of ansible-core within the execution environment. You will need to ensure that ansible-core is updated to a supported version while building the...

ensure correct handling of ansible_loop_var and ansible_index_var iin ansible.builtin.include_tasks

This has been resolved by https://github.com/ansible/ansible/pull/82789

ansible_loop_var and ansible_index_var not working with ansible.builtin.include_tasks

Looks like we just need to re-inject these vars for includes: ```diff diff --git a/lib/ansible/playbook/included_file.py b/lib/ansible/playbook/included_file.py index 8ec4397712..d2fdb76364 100644 --- a/lib/ansible/playbook/included_file.py +++ b/lib/ansible/playbook/included_file.py @@ -95,8 +95,10 @@ class IncludedFile: index_var...

ansible_loop_var and ansible_index_var not working with ansible.builtin.include_tasks

Anyone interested in turning the above diff into a PR with changelog and tests is free to do so.

Eaiser package mgr overrides

> Idle curiosity. With this change, is it possible for a playbook or role to use `set_fact` to override the `pkg_mgr` mid-flight during a playbook? Technically yes. But this introduces...

Eaiser package mgr overrides

fwiw, we can merge this ahead of my [PR](https://github.com/ansible/ansible/pull/82881) to address how the templating happens in package to safely evaluate the expression, specifically for `delegate_to`. The plan for my PR...

Eaiser package mgr overrides

We should probably add tests for this as well 🙂