Situ Chandra Shil

Results 202 comments of Situ Chandra Shil

Adds optimistic data for transaction threads with violations

Code looking good so far. Is this PR supposed to fix https://github.com/Expensify/App/issues/33114 as well?

Adds optimistic data for transaction threads with violations

## Reviewer Checklist - [x] I have verified the author checklist is complete (all boxes are checked off). - [x] I verified the correct issue is linked in the `###...

Adds optimistic data for transaction threads with violations

> Looks like typecheck is failing on main. yes, it's known. Should be fixed soon

Adds optimistic data for transaction threads with violations

Please merge main. Lint fixed now

Adds optimistic data for transaction threads with violations

There's conflict. Just to confirm all comments are addressed?

Adds optimistic data for transaction threads with violations

I was just waiting for fixing conflict

Adds optimistic data for transaction threads with violations

@cdanwards `splitBill`, `splitBillAndOpenReport` params are updated again in https://github.com/Expensify/App/pull/35141. `created` was sandwiched between `merchant` and `category` Please update accordingly. Actually, I don't think `MoneyRequestConfirmPage` is used anywhere. If you confirmed,...

Adds optimistic data for transaction threads with violations

And I see you linked https://github.com/Expensify/App/issues/33114 as well. Then you should add that test case in QA Steps as well.

Adds optimistic data for transaction threads with violations

Please resolve conflict when you get a chance

Adds optimistic data for transaction threads with violations

Maybe not caused by this PR but minus amount shows in header after creating offline request